fix(adk): remove direct log.Printf calls from retryModelWrapper#978
Open
octo-patch wants to merge 1 commit into
Open
fix(adk): remove direct log.Printf calls from retryModelWrapper#978octo-patch wants to merge 1 commit into
octo-patch wants to merge 1 commit into
Conversation
Remove the three log.Printf calls in retry_chatmodel.go that output retry events directly to the user terminal. Users can observe retry events via the WillRetryError emitted through AgentEvent, and can implement their own logging via IsRetryAble callbacks if needed. Fixes cloudwego#938
shentongmartin
added
C-bugfix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #938
Problem
retry_chatmodel.gocallslog.Printfdirectly for retry events, which outputs to the user's terminal and interferes with their application output (e.g., TUI applications).Solution
Remove all three
log.Printfcalls. Users can already observe retry events via theWillRetryErroremitted throughAgentEvent, and can implement custom logging in theirIsRetryAblecallback if needed.Testing
The behavior change is straightforward: retry attempts no longer print to the terminal. Existing tests continue to pass since they don't assert on log output.